Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 738133002: Incremental parser fix: handle insertion of method parameters. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Incremental parser fix: handle insertion of method parameters. This bug was discovered by the incremental parse stress tester. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-19 18:32:48 UTC) #2
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-11-19 18:46:01 UTC) #3
Paul Berry
6 years, 1 month ago (2014-11-20 19:22:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41864 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698