Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pkg/analyzer/lib/src/generated/parser.dart

Issue 738133002: Incremental parser fix: handle insertion of method parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/parser_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/generated/parser.dart
diff --git a/pkg/analyzer/lib/src/generated/parser.dart b/pkg/analyzer/lib/src/generated/parser.dart
index 45a62e3a85f1480e523d5a5d20eb4de97379358d..7bd33af428fde76589e8a979fb219916cf2fada5 100644
--- a/pkg/analyzer/lib/src/generated/parser.dart
+++ b/pkg/analyzer/lib/src/generated/parser.dart
@@ -1388,6 +1388,11 @@ class IncrementalParseDispatcher implements AstVisitor<AstNode> {
} else if (identical(_oldNode, node.body)) {
//return parser.parseFunctionBody();
throw new InsufficientContextException();
+ } else if (identical(_oldNode, node.parameters)) {
+ // TODO(paulberry): if we want errors to be correct, we'll need to also
+ // call _validateFormalParameterList, and sometimes
+ // _validateModifiersForGetterOrSetterOrMethod.
+ return _parser.parseFormalParameterList();
}
return _notAChild(node);
}
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/parser_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698