Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1301)

Issue 732203003: Cleanup: remove flow-graph's cached copy of num stack locals as it can become stale if variables ge… (Closed)

Created:
6 years, 1 month ago by srdjan
Modified:
6 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Cleanup: remove flow-graph's cached copy of num stack locals as it can become stale if variables get added after flow graph is created. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=41791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M runtime/vm/flow_graph.h View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
srdjan
6 years, 1 month ago (2014-11-17 21:13:36 UTC) #2
Cutch
lgtm
6 years, 1 month ago (2014-11-17 21:23:43 UTC) #4
srdjan
6 years, 1 month ago (2014-11-17 21:24:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r41791 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698