Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: runtime/vm/flow_graph.cc

Issue 732203003: Cleanup: remove flow-graph's cached copy of num stack locals as it can become stale if variables ge… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/flow_graph.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph.h" 5 #include "vm/flow_graph.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/flow_graph_builder.h" 8 #include "vm/flow_graph_builder.h"
9 #include "vm/intermediate_language.h" 9 #include "vm/intermediate_language.h"
10 #include "vm/growable_array.h" 10 #include "vm/growable_array.h"
(...skipping 12 matching lines...) Expand all
23 GraphEntryInstr* graph_entry, 23 GraphEntryInstr* graph_entry,
24 intptr_t max_block_id) 24 intptr_t max_block_id)
25 : isolate_(Isolate::Current()), 25 : isolate_(Isolate::Current()),
26 parent_(), 26 parent_(),
27 current_ssa_temp_index_(0), 27 current_ssa_temp_index_(0),
28 max_block_id_(max_block_id), 28 max_block_id_(max_block_id),
29 builder_(builder), 29 builder_(builder),
30 parsed_function_(*builder.parsed_function()), 30 parsed_function_(*builder.parsed_function()),
31 num_copied_params_(builder.num_copied_params()), 31 num_copied_params_(builder.num_copied_params()),
32 num_non_copied_params_(builder.num_non_copied_params()), 32 num_non_copied_params_(builder.num_non_copied_params()),
33 num_stack_locals_(builder.num_stack_locals()),
34 graph_entry_(graph_entry), 33 graph_entry_(graph_entry),
35 preorder_(), 34 preorder_(),
36 postorder_(), 35 postorder_(),
37 reverse_postorder_(), 36 reverse_postorder_(),
38 optimized_block_order_(), 37 optimized_block_order_(),
39 constant_null_(NULL), 38 constant_null_(NULL),
40 constant_dead_(NULL), 39 constant_dead_(NULL),
41 constant_empty_context_(NULL), 40 constant_empty_context_(NULL),
42 block_effects_(NULL), 41 block_effects_(NULL),
43 licm_allowed_(true), 42 licm_allowed_(true),
(...skipping 1296 matching lines...) Expand 10 before | Expand all | Expand 10 after
1340 } 1339 }
1341 1340
1342 1341
1343 bool BlockEffects::IsSideEffectFreePath(BlockEntryInstr* from, 1342 bool BlockEffects::IsSideEffectFreePath(BlockEntryInstr* from,
1344 BlockEntryInstr* to) const { 1343 BlockEntryInstr* to) const {
1345 return available_at_[to->postorder_number()]->Contains( 1344 return available_at_[to->postorder_number()]->Contains(
1346 from->postorder_number()); 1345 from->postorder_number());
1347 } 1346 }
1348 1347
1349 } // namespace dart 1348 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698