Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 726593002: Reland "Suppress canonicalization of Unbox() instruction that can deoptimize." (Closed)

Created:
6 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
6 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Reland "Suppress canonicalization of Unbox() instruction that can deoptimize." This relands commit r41693 with additional fixes in canonicalization pass. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41736

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix range analysis #

Patch Set 3 : more fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -54 lines) Patch
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis.cc View 1 2 6 chunks +25 lines, -23 lines 0 comments Download
M runtime/vm/flow_graph_range_analysis_test.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 8 chunks +31 lines, -27 lines 0 comments Download
A tests/language/vm/canonicalization_preserves_deopt_test.dart View 1 2 1 chunk +41 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vyacheslav Egorov (Google)
6 years, 1 month ago (2014-11-13 15:35:32 UTC) #1
Florian Schneider
https://codereview.chromium.org/726593002/diff/1/runtime/vm/intermediate_language.cc File runtime/vm/intermediate_language.cc (right): https://codereview.chromium.org/726593002/diff/1/runtime/vm/intermediate_language.cc#newcode2037 runtime/vm/intermediate_language.cc:2037: if (!HasUses()) return NULL; Also check for CanDeoptimize() here?
6 years, 1 month ago (2014-11-13 15:47:06 UTC) #2
Vyacheslav Egorov (Google)
PTAL This includes range analysis fixes and more tests.
6 years, 1 month ago (2014-11-13 18:20:20 UTC) #3
Florian Schneider
LGTM. Maybe we should assert that if can_overflow is true, at least one of min- ...
6 years, 1 month ago (2014-11-14 10:32:26 UTC) #4
Vyacheslav Egorov (Google)
6 years, 1 month ago (2014-11-14 11:19:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 41736 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698