runtime/vm/flow_graph_range_analysis.h - Issue 726593002: Reland "Suppress canonicalization of Unbox() instruction that can deoptimize."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_range_analysis.h

Issue 726593002: Reland "Suppress canonicalization of Unbox() instruction that can deoptimize." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: more fixes Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_range_analysis.h

diff --git a/runtime/vm/flow_graph_range_analysis.h b/runtime/vm/flow_graph_range_analysis.h

index a4bc7e6cf6f1233899639e8c6eff1d967e97b7f2..3b39ba2a45e2508c0edb5b0deab36147f82382c8 100644

--- a/runtime/vm/flow_graph_range_analysis.h

+++ b/runtime/vm/flow_graph_range_analysis.h

@@ -440,7 +440,7 @@ class Range : public ZoneAllocated {

RangeBoundary* max,

Definition* left_defn);

- static bool Mul(const Range* left_range,

+ static void Mul(const Range* left_range,

const Range* right_range,

RangeBoundary* min,

RangeBoundary* max);

@@ -454,7 +454,7 @@ class Range : public ZoneAllocated {

RangeBoundary* min,

RangeBoundary* max);

- static bool And(const Range* left_range,

+ static void And(const Range* left_range,

const Range* right_range,

RangeBoundary* min,

RangeBoundary* max);

« no previous file with comments | « runtime/vm/flow_graph_optimizer.cc ('k') | runtime/vm/flow_graph_range_analysis.cc » ('j') | no next file with comments »