Report HintCode.UNUSED_ELEMENT for functions.

Report HintCode.UNUSED_ELEMENT for functions.

1 positive in dart2js
1 positive in analysis_server
0 positives in analyzer

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=41746

[Brian Wilkerson, 2014-11-14 18:52:57]

LGTM

https://codereview.chromium.org/725163004/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/725163004/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/resolver.dart:15818: element is FunctionElement
&& !element.isStatic) {
It always looks weird to me to have an empty then block. How about reversing the
condition?

[scheglov, 2014-11-14 19:08:09]

https://codereview.chromium.org/725163004/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/725163004/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/resolver.dart:15818: element is FunctionElement
&& !element.isStatic) {
On 2014/11/14 18:52:57, Brian Wilkerson wrote:
> It always looks weird to me to have an empty then block. How about reversing
the
> condition?

I agree in general, but in this case there are two reasons to use this form:

1. I it easier to understand what is checked if condition is not inverted.
2. We can use promoted type of "element" in element.isStatic after "element is
FunctionElement".

I will add a comment in the "then" block.
And remove the comment out code.

[scheglov, 2014-11-14 19:11:35]

Committed patchset #2 (id:20001) manually as 41746 (presubmit successful).