Report HintCode.UNUSED_ELEMENT for functions.

pkg/analyzer/lib/src/generated/resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.resolver;
 
 import 'dart:collection';
 import "dart:math" as math;
 
 import 'java_core.dart';
@@ skipping 15565 matching lines @@
     ClassElement enclosingClassOld = _enclosingClass;
     try {
       _enclosingClass = node.element;
       super.visitClassDeclaration(node);
     } finally {
       _enclosingClass = enclosingClassOld;
     }
   }
 
   @override
+  visitFunctionDeclaration(FunctionDeclaration node) {
+    ExecutableElement enclosingExecOld = _enclosingExec;
+    try {
+      _enclosingExec = node.element;
+      super.visitFunctionDeclaration(node);
+    } finally {
+      _enclosingExec = enclosingExecOld;
+    }
+  }
+
+  @override
+  visitFunctionExpression(FunctionExpression node) {
+    if (node.parent is! FunctionDeclaration) {
+      _useElement(node.element);
+    }
+    super.visitFunctionExpression(node);
+  }
+
+  @override
   visitMethodDeclaration(MethodDeclaration node) {
     ExecutableElement enclosingExecOld = _enclosingExec;
     try {
       _enclosingExec = node.element;
       super.visitMethodDeclaration(node);
     } finally {
       _enclosingExec = enclosingExecOld;
     }
   }
 
@@ skipping 136 matching lines @@
       _reportErrorForElement(
           HintCode.UNUSED_ELEMENT,
           element,
           [element.kind.displayName, element.displayName]);
     }
     super.visitClassElement(element);
   }
 
   @override
   visitFieldElement(FieldElement element) {
-    if (!element.isSynthetic && !_isReadMember(element)) {
+    if (!_isReadMember(element)) {
       _reportErrorForElement(
           HintCode.UNUSED_FIELD,
           element,
           [element.displayName]);
     }
     super.visitFieldElement(element);
   }
 
   @override
+  visitFunctionElement(FunctionElement element) {
+    if (!_isUsedElement(element)) {
+      _reportErrorForElement(
+          HintCode.UNUSED_ELEMENT,
+          element,
+          [element.kind.displayName, element.displayName]);
+    }
+    super.visitFunctionElement(element);
+  }
+
+  @override
   visitLocalVariableElement(LocalVariableElement element) {
     if (!_isUsedElement(element)) {
       _reportErrorForElement(
           HintCode.UNUSED_LOCAL_VARIABLE,
           element,
           [element.displayName]);
     }
   }
 
   @override
   visitMethodElement(MethodElement element) {
     if (!_isUsedMember(element)) {
       _reportErrorForElement(
           HintCode.UNUSED_ELEMENT,
           element,
           [element.kind.displayName, element.displayName]);
     }
     super.visitMethodElement(element);
   }
 
   @override
   visitPropertyAccessorElement(PropertyAccessorElement element) {
-    if (!element.isSynthetic && !_isUsedMember(element)) {
+    if (!_isUsedMember(element)) {
       _reportErrorForElement(
           HintCode.UNUSED_ELEMENT,
           element,
           [element.kind.displayName, element.displayName]);
     }
     super.visitPropertyAccessorElement(element);
   }
 
   bool _isUsedElement(Element element) {
-    if (element is! LocalVariableElement) {
+    if (element.isSynthetic) {
+      return true;
+    }
+    if (element is LocalVariableElement ||
+        element is FunctionElement && !element.isStatic) {

[Brian Wilkerson, 2014/11/14 18:52:57]

It always looks weird to me to have an empty then block. How about reversing the
condition?

[scheglov, 2014/11/14 19:08:09]

I agree in general, but in this case there are two reasons to use this form:

1. I it easier to understand what is checked if condition is not inverted.
2. We can use promoted type of "element" in element.isStatic after "element is
FunctionElement".

I will add a comment in the "then" block.
And remove the comment out code.

+    } else {
       if (element.isPublic) {
         return true;
       }
     }
+//    if (element is! LocalVariableElement) {
+//      if (element.isPublic) {
+//        return true;
+//      }
+//    }
     return _usedElements.elements.contains(element);
   }
 
   bool _isReadMember(Element element) {
     if (element.isPublic) {
       return true;
     }
+    if (element.isSynthetic) {
+      return true;
+    }
     return _usedElements.readMembers.contains(element.displayName);
   }
 
   bool _isUsedMember(Element element) {
     if (element.isPublic) {
       return true;
     }
+    if (element.isSynthetic) {
+      return true;
+    }
     if (_usedElements.members.contains(element.displayName)) {
       return true;
     }
     return _usedElements.elements.contains(element);
   }
 
   void _reportErrorForElement(ErrorCode errorCode, Element element, List<Object> arguments) {
     if (element != null) {
       _errorListener.onError(
           new AnalysisError.con2(
               element.source,
               element.nameOffset,
               element.displayName.length,
               errorCode,
               arguments));
     }
   }
 }