Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 724403003: Remove flaky check from reanalyze_concurrent_test. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove flaky check from reanalyze_concurrent_test. This should avoid sporadic false failures with this test. If in the future we genuinely regress bug 21448, there is a danger that this test won't catch it reliably, but that is mitigated by the fact that (a) even flaky failures do get noticed, and (b) the bug was severe enough that it probably would be noticed in manual testing. The extra risk seems worth it to avoid the sporadic false failures we've been seeing. BUG=dartbug.com/21638 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart View 2 chunks +2 lines, -20 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-20 21:51:47 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-20 21:52:38 UTC) #3
Paul Berry
6 years, 1 month ago (2014-11-20 22:52:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41870 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698