Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(910)

Unified Diff: pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart

Issue 724403003: Remove flaky check from reanalyze_concurrent_test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/pkg.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart
diff --git a/pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart b/pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart
index d84c165648d0609fbd1f43b61248b9ab5876dff1..25e8a4c0e6f39dc1f24e97f5ea7f17e5c137b1ea 100644
--- a/pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart
+++ b/pkg/analysis_server/test/integration/analysis/reanalyze_concurrent_test.dart
@@ -12,9 +12,6 @@ library test.integration.analysis.reanalyze_concurrent;
import 'dart:async';
-import 'package:analysis_server/src/protocol.dart';
-import 'package:unittest/unittest.dart';
-
import '../../reflective_tests.dart';
import '../integration_tests.dart';
@@ -41,23 +38,8 @@ main() {}''';
return onServerStatus.first.then((_) {
sendAnalysisReanalyze();
return analysisFinished.then((_) {
- // Now that reanalysis has finished, no further analysis should occur.
- onServerStatus.listen((ServerStatusParams data) {
- if (data.analysis != null) {
- if (data.analysis.isAnalyzing) {
- // Most likely what happened is that the first reanalyze
- // completed before the second reanalyze had a chance to start,
- // and we are just now starting the second reanalyze. If this
- // is the case, then the test isn't testing what it's meant to
- // test (because we are trying to test what happens when one
- // reanalyze starts while another is in progress). In which
- // case we will need to give the analyzer more work to do.
- fail('First reanalyze finished before second started.');
- }
- }
- });
- // Give the server an extra second to make sure it doesn't take any
- // more actions.
+ // Now that reanalysis has finished, give the server an extra second
+ // to make sure it doesn't crash.
return new Future.delayed(new Duration(seconds: 1));
});
});
« no previous file with comments | « no previous file | pkg/pkg.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698