Improve error reporting when a mixin application is invalid.

Improve error reporting when a mixin application is invalid.

For a situation like this:

  class B {
    B({int i});
  }
  class M {}
  class C extends B with M {
    C() : super();
  }

we report the error at the node "with M", with the message "This mixin
application is invalid because all of the constructors in the base
class 'B' have optional parameters.".

Previously we would report the error at the site of the super call,
leaving the user no idea why there was a problem.

BUG=dartbug.com/19576
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41745

[Paul Berry, 2014-11-13 22:31:50]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2014-11-13 23:02:47]

lgtm with question

https://codereview.chromium.org/724133003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element.dart (right):

https://codereview.chromium.org/724133003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element.dart:1062: bool get mixinErrorsReported;
Do we really need to add it to the API?
Can we add it only to the implementation, or even better - to one of the
resolution classes?

[Paul Berry, 2014-11-13 23:29:49]

On 2014/11/13 23:02:47, scheglov wrote:
> lgtm with question
> 
>
https://codereview.chromium.org/724133003/diff/1/pkg/analyzer/lib/src/generat...
> File pkg/analyzer/lib/src/generated/element.dart (right):
> 
>
https://codereview.chromium.org/724133003/diff/1/pkg/analyzer/lib/src/generat...
> pkg/analyzer/lib/src/generated/element.dart:1062: bool get
mixinErrorsReported;
> Do we really need to add it to the API?
> Can we add it only to the implementation, or even better - to one of the
> resolution classes?

I'm ok with removing it from the API.  I'm not sure what you mean by adding it
to one of the resolution classes, though--how would that work?

[scheglov, 2014-11-13 23:57:01]

On 2014/11/13 23:29:49, Paul Berry wrote:
> On 2014/11/13 23:02:47, scheglov wrote:
> > lgtm with question
> > 
> >
>
https://codereview.chromium.org/724133003/diff/1/pkg/analyzer/lib/src/generat...
> > File pkg/analyzer/lib/src/generated/element.dart (right):
> > 
> >
>
https://codereview.chromium.org/724133003/diff/1/pkg/analyzer/lib/src/generat...
> > pkg/analyzer/lib/src/generated/element.dart:1062: bool get
> mixinErrorsReported;
> > Do we really need to add it to the API?
> > Can we add it only to the implementation, or even better - to one of the
> > resolution classes?
> 
> I'm ok with removing it from the API.  I'm not sure what you mean by adding it
> to one of the resolution classes, though--how would that work?

Never mind, I missed the fact that mixinErrorsReported is set in the enclosing
class, not in mixed in classes.

[Paul Berry, 2014-11-14 18:05:29]

Committed patchset #1 (id:1) manually as 41745 (presubmit successful).