pkg/analyzer/lib/src/generated/element_resolver.dart - Issue 724133003: Improve error reporting when a mixin application is invalid.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/lib/src/generated/element_resolver.dart

Issue 724133003: Improve error reporting when a mixin application is invalid. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analyzer/lib/src/generated/element.dart ('K') | « pkg/analyzer/lib/src/generated/element_handle.dart ('k') | pkg/analyzer/lib/src/generated/error_verifier.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/lib/src/generated/element_resolver.dart

diff --git a/pkg/analyzer/lib/src/generated/element_resolver.dart b/pkg/analyzer/lib/src/generated/element_resolver.dart

index e10f99b70b0a8ff1d4a7c9061c811dc863d33a05..268b489fc7ce8afb3e490acaa6d964e9fe0a2fa3 100644

--- a/pkg/analyzer/lib/src/generated/element_resolver.dart

+++ b/pkg/analyzer/lib/src/generated/element_resolver.dart

@@ -1062,7 +1062,8 @@ class ElementResolver extends SimpleAstVisitor<Object> {

String superName = name != null ? name.name : null;

ConstructorElement element = superType.lookUpConstructor(superName, _definingLibrary);

if (element == null ||

- !enclosingClass.isSuperConstructorAccessible(element)) {

+ (!enclosingClass.mixinErrorsReported &&

+ !enclosingClass.isSuperConstructorAccessible(element))) {

if (name != null) {

_resolver.reportErrorForNode(CompileTimeErrorCode.UNDEFINED_CONSTRUCTOR_IN_INITIALIZER, node, [superType.displayName, name]);

} else {