Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 718073002: Put test shared options before filename in compilation commands. (Closed)

Created:
6 years, 1 month ago by Bill Hesse
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Put test shared options before filename in compilation commands. BUG=dartbug.com/21582 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/testing/dart/test_suite.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Bill Hesse
6 years, 1 month ago (2014-11-12 15:31:31 UTC) #2
ricow1
lgtm, please file a bug with the analyzer team to fix this though. Unless there ...
6 years, 1 month ago (2014-11-13 07:37:15 UTC) #4
Bill Hesse
6 years, 1 month ago (2014-11-13 09:17:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41708 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698