Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 718073002: Put test shared options before filename in compilation commands. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 991 matching lines...) Expand 10 before | Expand all | Expand 10 after
1002 List<Command> makeCommands(TestInformation info, var vmOptions, var args) { 1002 List<Command> makeCommands(TestInformation info, var vmOptions, var args) {
1003 List<Command> commands = <Command>[]; 1003 List<Command> commands = <Command>[];
1004 CompilerConfiguration compilerConfiguration = 1004 CompilerConfiguration compilerConfiguration =
1005 new CompilerConfiguration(configuration); 1005 new CompilerConfiguration(configuration);
1006 List<String> sharedOptions = info.optionsFromFile['sharedOptions']; 1006 List<String> sharedOptions = info.optionsFromFile['sharedOptions'];
1007 1007
1008 List<String> compileTimeArguments = <String>[]; 1008 List<String> compileTimeArguments = <String>[];
1009 String tempDir; 1009 String tempDir;
1010 if (compilerConfiguration.hasCompiler) { 1010 if (compilerConfiguration.hasCompiler) {
1011 compileTimeArguments 1011 compileTimeArguments
1012 ..addAll(args) 1012 ..addAll(sharedOptions)
1013 ..addAll(sharedOptions); 1013 ..addAll(args);
1014 // Avoid doing this for analyzer. 1014 // Avoid doing this for analyzer.
1015 tempDir = createCompilationOutputDirectory(info.filePath); 1015 tempDir = createCompilationOutputDirectory(info.filePath);
1016 } 1016 }
1017 1017
1018 CommandArtifact compilationArtifact = 1018 CommandArtifact compilationArtifact =
1019 compilerConfiguration.computeCompilationArtifact( 1019 compilerConfiguration.computeCompilationArtifact(
1020 buildDir, 1020 buildDir,
1021 tempDir, 1021 tempDir,
1022 CommandBuilder.instance, 1022 CommandBuilder.instance,
1023 compileTimeArguments, 1023 compileTimeArguments,
(...skipping 1458 matching lines...) Expand 10 before | Expand all | Expand 10 after
2482 * $pass tests are expected to pass 2482 * $pass tests are expected to pass
2483 * $failOk tests are expected to fail that we won't fix 2483 * $failOk tests are expected to fail that we won't fix
2484 * $fail tests are expected to fail that we should fix 2484 * $fail tests are expected to fail that we should fix
2485 * $crash tests are expected to crash that we should fix 2485 * $crash tests are expected to crash that we should fix
2486 * $timeout tests are allowed to timeout 2486 * $timeout tests are allowed to timeout
2487 * $compileErrorSkip tests are skipped on browsers due to compile-time error 2487 * $compileErrorSkip tests are skipped on browsers due to compile-time error
2488 """; 2488 """;
2489 print(report); 2489 print(report);
2490 } 2490 }
2491 } 2491 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698