Issue 717513003: Issue 21552. Fixes for navigation, hover and rename in instance creation expressions.

Issue 717513003: Issue 21552. Fixes for navigation, hover and rename in instance creation expressions. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 21552. Fixes for navigation, hover and rename in instance creation expressions. R=brianwilkerson@google.com, paulberry@google.com BUG= https://code.google.com/p/dart/issues/detail?id=21552 Committed: https://code.google.com/p/dart/source/detail?r=41651

Patch Set 1 #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+292 lines, -186 lines)			Patch
M	pkg/analysis_server/lib/src/computer/computer_hover.dart	View	2 chunks	+16 lines, -5 lines	0 comments	Download
M	pkg/analysis_server/lib/src/computer/computer_navigation.dart	View	1 chunk	+16 lines, -14 lines	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	pkg/analysis_server/test/analysis/get_hover_test.dart	View	2 chunks	+87 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/analysis/notification_navigation_test.dart	View	7 chunks	+20 lines, -49 lines	2 comments	Download
M	pkg/analysis_server/test/edit/refactoring_test.dart	View	6 chunks	+144 lines, -117 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/717513003/diff/1/pkg/analysis_server/test/analysis/notification_navigation_test.dart File pkg/analysis_server/test/analysis/notification_navigation_test.dart (right): https://codereview.chromium.org/717513003/diff/1/pkg/analysis_server/test/analysis/notification_navigation_test.dart#newcode70 pkg/analysis_server/test/analysis/notification_navigation_test.dart:70: * with the length of [search]. The comment ...

6 years, 1 month ago (2014-11-10 21:04:24 UTC) #2

scheglov

https://codereview.chromium.org/717513003/diff/1/pkg/analysis_server/test/analysis/notification_navigation_test.dart File pkg/analysis_server/test/analysis/notification_navigation_test.dart (right): https://codereview.chromium.org/717513003/diff/1/pkg/analysis_server/test/analysis/notification_navigation_test.dart#newcode70 pkg/analysis_server/test/analysis/notification_navigation_test.dart:70: * with the length of [search]. On 2014/11/10 21:04:23, ...

6 years, 1 month ago (2014-11-11 03:01:06 UTC) #4

scheglov

6 years, 1 month ago (2014-11-11 03:01:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41651 (presubmit successful).

Expand Messages | Collapse Messages