Issue 21552. Fixes for navigation, hover and rename in instance creation expressions.

pkg/analysis_server/lib/src/computer/computer_navigation.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library computer.navigation;
 
 import 'package:analysis_server/src/protocol_server.dart' as protocol;
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/scanner.dart';
@@ skipping 150 matching lines @@
   @override
   visitInstanceCreationExpression(InstanceCreationExpression node) {
     Element element = node.staticElement;
     ConstructorName constructorName = node.constructorName;
     if (element != null && constructorName != null) {
       // if a synthetic constructor, navigate to the class
       if (element.isSynthetic) {
         ClassElement classElement = element.enclosingElement;
         element = classElement;
       }
-      // "new ", excluding last character
-      computer._addRegion_nodeStart_nodeStart(
-          node,
-          constructorName.type,
-          element,
-          excludeLastChar: true);
-      // "ClassName<TypeA, TypeB>"
-      _safelyVisit(constructorName.type);
-      // optional ".name"
-      if (constructorName.period != null) {
-        computer._addRegion_tokenStart_nodeEnd(
-            constructorName.period,
-            constructorName,
-            element);
+      // add regions
+      TypeName typeName = constructorName.type;
+      TypeArgumentList typeArguments = typeName.typeArguments;
+      if (typeArguments == null) {
+        computer._addRegion_nodeStart_nodeEnd(node, constructorName, element);
+      } else {
+        computer._addRegion_nodeStart_nodeEnd(node, typeName.name, element);
+        // <TypeA, TypeB>
+        typeArguments.accept(this);
+        // optional ".name"
+        if (constructorName.period != null) {
+          computer._addRegion_tokenStart_nodeEnd(
+              constructorName.period,
+              constructorName,
+              element);
+        }
       }
     }
     _safelyVisit(node.argumentList);
   }
 
   @override
   visitPartDirective(PartDirective node) {
     computer._addRegion_tokenStart_nodeEnd(
         node.keyword,
         node.uri,
@@ skipping 30 matching lines @@
     Element element = node.bestElement;
     computer._addRegionForNode(node, element);
   }
 
   void _safelyVisit(AstNode node) {
     if (node != null) {
       node.accept(this);
     }
   }
 }