Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 71453008: Remove use of deprecated mirror functions from Dartium's dart:html. (Closed)

Created:
7 years, 1 month ago by rmacnak
Modified:
7 years, 1 month ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove use of deprecated mirror functions from Dartium's dart:html. BUG=http://dartbug.com/14931 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=30259

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tools/dom/dom.json View 1 chunk +1 line, -1 line 1 comment Download
M tools/dom/src/native_DOMImplementation.dart View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
https://codereview.chromium.org/71453008/diff/1/tools/dom/dom.json File tools/dom/dom.json (right): https://codereview.chromium.org/71453008/diff/1/tools/dom/dom.json#newcode13087 tools/dom/dom.json:13087: } Spurious whitespace change by dom/scripts/go.sh
7 years, 1 month ago (2013-11-13 23:23:29 UTC) #1
vsm
lgtm
7 years, 1 month ago (2013-11-13 23:42:53 UTC) #2
rmacnak
7 years, 1 month ago (2013-11-13 23:50:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30259 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698