Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.
Issue 71453008: Remove use of deprecated mirror functions from Dartium's dart:html. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | tools/dom/dom.json » ('j') | tools/dom/dom.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dartium/html_dartium.dart
diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart
index a8fb84096fd0ddc6ccec03db9673e3cc3e3da4da..5806619548ee06dad002e7a20cc30c4cf0fcf9d0 100644
--- a/sdk/lib/html/dartium/html_dartium.dart
+++ b/sdk/lib/html/dartium/html_dartium.dart
@@ -36469,7 +36469,7 @@ class _Utils {
addForClass(ClassMirror mirror, bool isStatic) {
if (mirror == null)
return;
- addAll(mirror.members, isStatic);
+ addAll(mirror.declarations, isStatic);
if (mirror.superclass != null)
addForClass(mirror.superclass, isStatic);
for (var interface in mirror.superinterfaces) {
@@ -36590,7 +36590,9 @@ class _Utils {
}
var className = MirrorSystem.getName(cls.simpleName);
var createdConstructor = cls.constructors[new Symbol('$className.created')];
- if (createdConstructor == null) {
+ if (createdConstructor == null ||
+ createdConstructor is! MethodMirror ||
+ !createdConstructor.isConstructor) {
throw new UnsupportedError(
'Class is missing constructor $className.created');
}
« no previous file with comments | « no previous file | tools/dom/dom.json » ('j') | tools/dom/dom.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698