Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 710163002: Add support for type references to AccessSemantics. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Add support for type references to AccessSemantics. We now handle references to toplevel classes, e.g.: class C {} Type t = C; And references to type parameters, e.g.: class C<T> { f() { Type t = T; } } R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41643

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -9 lines) Patch
M pkg/analyzer2dart/lib/src/identifier_semantics.dart View 6 chunks +34 lines, -9 lines 2 comments Download
M pkg/analyzer2dart/lib/src/semantic_visitor.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/identifier_semantics_test.dart View 2 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Paul Berry
6 years, 1 month ago (2014-11-10 18:39:40 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-10 18:48:11 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as 41643 (presubmit successful).
6 years, 1 month ago (2014-11-10 19:14:08 UTC) #4
Johnni Winther
https://codereview.chromium.org/710163002/diff/1/pkg/analyzer2dart/lib/src/identifier_semantics.dart File pkg/analyzer2dart/lib/src/identifier_semantics.dart (right): https://codereview.chromium.org/710163002/diff/1/pkg/analyzer2dart/lib/src/identifier_semantics.dart#newcode484 pkg/analyzer2dart/lib/src/identifier_semantics.dart:484: return new AccessSemantics.toplevelClass(node, staticElement); How do you handle 'dynamic' ...
6 years, 1 month ago (2014-11-11 12:49:45 UTC) #6
Paul Berry
6 years, 1 month ago (2014-11-11 13:22:34 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/710163002/diff/1/pkg/analyzer2dart/lib/src/id...
File pkg/analyzer2dart/lib/src/identifier_semantics.dart (right):

https://codereview.chromium.org/710163002/diff/1/pkg/analyzer2dart/lib/src/id...
pkg/analyzer2dart/lib/src/identifier_semantics.dart:484: return new
AccessSemantics.toplevelClass(node, staticElement);
On 2014/11/11 12:49:45, Johnni Winther wrote:
> How do you handle 'dynamic' as a type literal?

Whoops, I forgot to handle this case.  I also forgot to handle the case where
the thing being accessed is a top-level function typedef.

I'll follow up with another CL.

Powered by Google App Engine
This is Rietveld 408576698