Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: pkg/analyzer2dart/test/identifier_semantics_test.dart

Issue 710163002: Add support for type references to AccessSemantics. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer2dart/test/identifier_semantics_test.dart
diff --git a/pkg/analyzer2dart/test/identifier_semantics_test.dart b/pkg/analyzer2dart/test/identifier_semantics_test.dart
index b9a3044cd3de56a832ac6f954a2e166780646aae..b5a05b7ec3786f74eed89d7512cc7306d807b464 100644
--- a/pkg/analyzer2dart/test/identifier_semantics_test.dart
+++ b/pkg/analyzer2dart/test/identifier_semantics_test.dart
@@ -1092,6 +1092,39 @@ f() {
helper.checkDynamic('h().x', 'h()', 'x', isRead: true);
});
+ test('Get class defined at top level', () {
+ Helper helper = new Helper('''
+class A {}
+var t = A;
+''');
+ helper.checkTypeReference('A', 'A', AccessKind.TOPLEVEL_CLASS);
+ });
+
+ test('Get class defined at top level via prefix', () {
+ Helper helper = new Helper('''
+import 'lib.dart' as l;
+
+var t = l.A;
+''');
+ helper.addFile('/lib.dart', '''
+library lib;
+
+class A;
+''');
+ helper.checkTypeReference('l.A', 'A', AccessKind.TOPLEVEL_CLASS);
+ });
+
+ test('Get type parameter of enclosing class', () {
+ Helper helper = new Helper('''
+class A<T, U> {
+ f() {
+ var t = U;
+ }
+}
+''');
+ helper.checkTypeReference('U', 'U', AccessKind.TYPE_PARAMETER);
+ });
+
test('Set variable defined at top level', () {
Helper helper = new Helper('''
var x;
@@ -2225,6 +2258,29 @@ class Helper {
libraryElement.unit.accept(visitor);
expect(count, equals(1));
}
+
+ /**
+ * Verify that the node represented by [expectedSource] is classified as a
+ * reference to a toplevel class or a type parameter.
+ */
+ void checkTypeReference(
+ String expectedSource, String expectedName, AccessKind expectedKind) {
+ TestVisitor visitor = new TestVisitor();
+ int count = 0;
+ visitor.onAccess = (AstNode node, AccessSemantics semantics) {
+ count++;
+ expect(node.toSource(), equals(expectedSource));
+ expect(semantics.kind, equals(expectedKind));
+ expect(semantics.element.name, equals(expectedName));
+ expect(semantics.classElement, isNull);
+ expect(semantics.target, isNull);
+ expect(semantics.isRead, isTrue);
+ expect(semantics.isWrite, isFalse);
+ expect(semantics.isInvoke, isFalse);
+ };
+ libraryElement.unit.accept(visitor);
+ expect(count, equals(1));
+ }
}
typedef void AccessHandler(Expression node, AccessSemantics semantics);

Powered by Google App Engine
This is Rietveld 408576698