Support dart and js scripts in HTML tests, on dartium.

Support dart and js scripts in HTML tests, on dartium.

BUG=
R=ricow@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41569

[Bill Hesse, 2014-11-05 10:49:12]

whesse@google.com changed reviewers:
+ ricow@google.com

[ricow1, 2014-11-05 10:59:55]

https://codereview.chromium.org/705733003/diff/20001/tests/html/scripts_test_...
File tests/html/scripts_test_js.js (right):

https://codereview.chromium.org/705733003/diff/20001/tests/html/scripts_test_...
tests/html/scripts_test_js.js:8: parent.postMessage('cow', '*');  // Unexpected
message OK.
why parent here and not window?

https://codereview.chromium.org/705733003/diff/20001/tools/testing/dart/test_...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/705733003/diff/20001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:1182: DebugLogger.warning('HTML test scripts
must be dart or javascript: '
fail the test?

https://codereview.chromium.org/705733003/diff/20001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:1189: DebugLogger.warning('HTML test scripts
must have relative paths: '
fail the test?

https://codereview.chromium.org/705733003/diff/20001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:1194: DebugLogger.warning('HTML test scripts
must be in test directory: '
fail the test?

https://codereview.chromium.org/705733003/diff/20001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:1205: DebugLogger.error('HTML test scripts
don\'t support dart2js yet: '
so can you even land this?

[Bill Hesse, 2014-11-05 12:51:51]

Addressed comments.

https://codereview.chromium.org/705733003/diff/20001/tests/html/scripts_test_...
File tests/html/scripts_test_js.js (right):

https://codereview.chromium.org/705733003/diff/20001/tests/html/scripts_test_...
tests/html/scripts_test_js.js:8: parent.postMessage('cow', '*');  // Unexpected
message OK.
On 2014/11/05 10:59:54, ricow1 wrote:
> why parent here and not window?

WE want to test that sending to parent does not break anything.  Comment was
wrong.  Added another line that tests an unexpected message to window.

https://codereview.chromium.org/705733003/diff/20001/tools/testing/dart/test_...
File tools/testing/dart/test_suite.dart (right):

https://codereview.chromium.org/705733003/diff/20001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:1182: DebugLogger.warning('HTML test scripts
must be dart or javascript: '
On 2014/11/05 10:59:54, ricow1 wrote:
> fail the test?

Done.

https://codereview.chromium.org/705733003/diff/20001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:1189: DebugLogger.warning('HTML test scripts
must have relative paths: '
On 2014/11/05 10:59:55, ricow1 wrote:
> fail the test?

Done.

https://codereview.chromium.org/705733003/diff/20001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:1194: DebugLogger.warning('HTML test scripts
must be in test directory: '
On 2014/11/05 10:59:55, ricow1 wrote:
> fail the test?

Done.

https://codereview.chromium.org/705733003/diff/20001/tools/testing/dart/test_...
tools/testing/dart/test_suite.dart:1205: DebugLogger.error('HTML test scripts
don\'t support dart2js yet: '
On 2014/11/05 10:59:55, ricow1 wrote:
> so can you even land this?

line 1169 skipped all platforms without compiler == none, but I have removed
that, and put the script test in the status file for dart2js and dart2dart
platforms.

[ricow1, 2014-11-05 12:58:06]

lgtm

[Bill Hesse, 2014-11-06 17:03:36]

Committed patchset #3 (id:40001) manually as 41569 (presubmit successful).