tools/testing/dart/html_test.dart - Issue 705733003: Support dart and js scripts in HTML tests, on dartium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/html_test.dart

Issue 705733003: Support dart and js scripts in HTML tests, on dartium. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/html_test.dart

diff --git a/tools/testing/dart/html_test.dart b/tools/testing/dart/html_test.dart

index ef2119a2d325d39c7cf56206d7a2a944bcf92887..a3a3506aebe84936a68c8bc1d95f57f0645836c9 100644

--- a/tools/testing/dart/html_test.dart

+++ b/tools/testing/dart/html_test.dart

@@ -44,4 +44,22 @@ HtmlTestInformation getInformation(String filename) {

String getContents(HtmlTestInformation info) {

String contents = new File(info.filePath.toNativePath()).readAsStringSync();

return contents.replaceFirst(htmlAnnotation, '');

+String makeFailingHtmlFile(String message) {

+ return '''

+<!DOCTYPE html>

+<html>

+<head>

+ <script>window.parent.dispatchEvent(new Event('detect_errors'));</script>

+ <title>Failing HTML test</title>

+</head><body>

+ <h1>Failing HTML test</h1>

+ $message

+ <script>

+ throw "HTML test failed: $message";

+ </script>

+</body>

+</html>

+''';

« no previous file with comments | « tests/html/scripts_test_js.js ('k') | tools/testing/dart/test_suite.dart » ('j') | no next file with comments »