Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 702473002: Fix access semantics for foreach loops. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Fix access semantics for foreach loops. In a statement like: for (x in ...) { ... } "x" needs to be considered to be in setter context, not getter context. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41460

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/identifier_semantics_test.dart View 10 chunks +118 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-03 15:08:15 UTC) #2
scheglov
lgtm Would be good to update also SimpleIdentifierTest itself.
6 years, 1 month ago (2014-11-03 15:22:45 UTC) #3
Paul Berry
On 2014/11/03 15:22:45, scheglov wrote: > lgtm > > Would be good to update also ...
6 years, 1 month ago (2014-11-03 16:44:34 UTC) #4
Paul Berry
6 years, 1 month ago (2014-11-03 16:47:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41460 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698