Fix access semantics for foreach loops.

pkg/analyzer2dart/test/identifier_semantics_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'package:unittest/unittest.dart';
 import 'package:analyzer/file_system/memory_file_system.dart';
 import 'mock_sdk.dart';
 import 'package:analyzer/src/generated/sdk.dart';
 import 'package:analyzer/file_system/file_system.dart';
 import 'package:analyzer/src/generated/source.dart';
@@ skipping 1085 matching lines @@
     Helper helper = new Helper('''
 var x;
 
 f() {
   x = 1;
 }
 ''');
     helper.checkStaticField('x', null, 'x', isWrite: true);
   });
 
+  test('Set variable defined at top level in foreach loop', () {
+    Helper helper = new Helper('''
+var x;
+
+f() {
+  for (x in []) {}
+}
+''');
+    helper.checkStaticField('x', null, 'x', isWrite: true);
+  });
+
   test('Set variable defined at top level via prefix', () {
     Helper helper = new Helper('''
 import 'lib.dart' as l;
 
 f() {
   l.x = 1;
 }
 ''');
     helper.addFile('/lib.dart', '''
 library lib;
 
 var x;
 ''');
     helper.checkStaticField('l.x', null, 'x', isWrite: true);
   });
 
   test('Set field defined statically in class from inside class', () {
     Helper helper = new Helper('''
 class A {
   static var x;
 
   f() {
     x = 1;
   }
 }
 ''');
     helper.checkStaticField('x', 'A', 'x', isWrite: true);
   });
 
+  test('Set field defined statically in class from inside class in foreach' +
+      ' loop', () {
+    Helper helper = new Helper('''
+class A {
+  static var x;
+
+  f() {
+    for (x in []) {}
+  }
+}
+''');
+    helper.checkStaticField('x', 'A', 'x', isWrite: true);
+  });
+
   test('Set field defined statically in class from outside class', () {
     Helper helper = new Helper('''
 class A {
   static var x;
 }
 
 f() {
   A.x = 1;
 }
 ''');
@@ skipping 26 matching lines @@
   var x;
 
   f() {
     x = 1;
   }
 }
 ''');
     helper.checkDynamic('x', null, 'x', isWrite: true);
   });
 
+  test('Set field defined dynamically in class from inside class in foreach' +
+      ' loop', () {
+    Helper helper = new Helper('''
+class A {
+  var x;
+
+  f() {
+    for (x in []) {}
+  }
+}
+''');
+    helper.checkDynamic('x', null, 'x', isWrite: true);
+  });
+
   test(
       'Set field defined dynamically in class from outside class via typed var',
       () {
     Helper helper = new Helper('''
 class A {
   var x;
 }
 
 f(A a) {
   a.x = 1;
@@ skipping 22 matching lines @@
   test('Set variable defined locally', () {
     Helper helper = new Helper('''
 f() {
   var x;
   x = 1;
 }
 ''');
     helper.checkLocalVariable('x', 'x', isWrite: true);
   });
 
+  test('Set variable defined locally in foreach loop', () {
+    Helper helper = new Helper('''
+f() {
+  var x;
+  for (x in []) {}
+}
+''');
+    helper.checkLocalVariable('x', 'x', isWrite: true);
+  });
+
   test('Set variable defined in parameter', () {
     Helper helper = new Helper('''
 f(x) {
   x = 1;
 }
 ''');
     helper.checkParameter('x', 'x', isWrite: true);
   });
 
+  test('Set variable defined in parameter in foreach loop', () {
+    Helper helper = new Helper('''
+f(x) {
+  for (x in []) {}
+}
+''');
+    helper.checkParameter('x', 'x', isWrite: true);
+  });
+
   test('Set accessor defined at top level', () {
     Helper helper = new Helper('''
 set x(value) {};
 
 f() {
   x = 1;
 }
 ''');
     helper.checkStaticProperty('x', null, 'x', true, isWrite: true);
   });
 
+  test('Set accessor defined at top level in foreach loop', () {
+    Helper helper = new Helper('''
+set x(value) {};
+
+f() {
+  for (x in []) {}
+}
+''');
+    helper.checkStaticProperty('x', null, 'x', true, isWrite: true);
+  });
+
   test('Set accessor defined at top level via prefix', () {
     Helper helper = new Helper('''
 import 'lib.dart' as l;
 
 f() {
   l.x = 1;
 }
 ''');
     helper.addFile('/lib.dart', '''
 library lib;
 
 set x(value) {};
 ''');
     helper.checkStaticProperty('l.x', null, 'x', true, isWrite: true);
   });
 
   test('Set accessor defined statically in class from inside class', () {
     Helper helper = new Helper('''
 class A {
   static set x(value) {}
 
   f() {
     x = 1;
   }
 }
 ''');
     helper.checkStaticProperty('x', 'A', 'x', true, isWrite: true);
   });
 
+  test('Set accessor defined statically in class from inside class in' +
+      ' foreach loop', () {
+    Helper helper = new Helper('''
+class A {
+  static set x(value) {}
+
+  f() {
+    for (x in []) {}
+  }
+}
+''');
+    helper.checkStaticProperty('x', 'A', 'x', true, isWrite: true);
+  });
+
   test('Set accessor defined statically in class from outside class', () {
     Helper helper = new Helper('''
 class A {
   static set x(value) {}
 }
 
 f() {
   A.x = 1;
 }
 ''');
@@ skipping 26 matching lines @@
   set x(value) {}
 
   f() {
     x = 1;
   }
 }
 ''');
     helper.checkDynamic('x', null, 'x', isWrite: true);
   });
 
+  test('Set accessor defined dynamically in class from inside class in' +
+      ' foreach loop', () {
+    Helper helper = new Helper('''
+class A {
+  set x(value) {}
+
+  f() {
+    for (x in []) {}
+  }
+}
+''');
+    helper.checkDynamic('x', null, 'x', isWrite: true);
+  });
+
   test(
       'Set accessor defined dynamically in class from outside class via typed var',
       () {
     Helper helper = new Helper('''
 class A {
   set x(value) {}
 }
 
 f(A a) {
   a.x = 1;
@@ skipping 45 matching lines @@
 
   test('Set accessor undefined at top level', () {
     Helper helper = new Helper('''
 f() {
   x = 1;
 }
 ''');
     helper.checkDynamic('x', null, 'x', isWrite: true);
   });
 
+  test('Set accessor undefined at top level in foreach loop', () {
+    Helper helper = new Helper('''
+f() {
+  for (x in []) {}
+}
+''');
+    helper.checkDynamic('x', null, 'x', isWrite: true);
+  });
+
   test('Set accessor undefined at top level via prefix', () {
     Helper helper = new Helper('''
 import 'lib.dart' as l;
 
 f() {
   l.x = 1;
 }
 ''');
     helper.addFile('/lib.dart', '''
 library lib;
@@ skipping 34 matching lines @@
     Helper helper = new Helper('''
 class A {
   f() {
     x = 1;
   }
 }
 ''');
     helper.checkDynamic('x', null, 'x', isWrite: true);
   });
 
+  test('Set accessor undefined dynamically in class from inside class in' +
+      ' foreach loop', () {
+    Helper helper = new Helper('''
+class A {
+  f() {
+    for (x in []) {}
+  }
+}
+''');
+    helper.checkDynamic('x', null, 'x', isWrite: true);
+  });
+
   test(
       'Set accessor undefined dynamically in class from outside class via typed var',
       () {
     Helper helper = new Helper('''
 class A {}
 
 f(A a) {
   a.x = 1;
 }
 ''');
@@ skipping 686 matching lines @@
   }
 
   @override
   visitSimpleIdentifier(SimpleIdentifier node) {
     AccessSemantics semantics = node.accept(ACCESS_SEMANTICS_VISITOR);
     if (semantics != null) {
       onAccess(node, semantics);
     }
   }
 }