Implement bigint intrinsics on arm64.

Implement bigint intrinsics on arm64.
Implement umaddl arm64 instruction (assembler, disassembler, simulator, tests).
Finish implementing cbz and cbnz arm64 instructions (assembler, tests).

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41608

[regis, 2014-11-05 21:28:51]

regis@google.com changed reviewers:
+ zra@google.com

[regis, 2014-11-05 21:28:51]

I'd also be interested to check if it works on the hardware. Thanks!

-- Regis

[zra, 2014-11-06 00:30:59]

https://codereview.chromium.org/701233003/diff/1/runtime/vm/assembler_arm64.h
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/701233003/diff/1/runtime/vm/assembler_arm64.h...
runtime/vm/assembler_arm64.h:1675: void EmitCompareAndBranch(CompareAndBranchOp
op, Register rt,
You also need to detect these instructions in Bind in assembler_arm64.cc and
make the right fixups.

[regis, 2014-11-06 18:43:51]

On 2014/11/06 00:30:59, zra wrote:
> https://codereview.chromium.org/701233003/diff/1/runtime/vm/assembler_arm64.h
> File runtime/vm/assembler_arm64.h (right):
> 
>
https://codereview.chromium.org/701233003/diff/1/runtime/vm/assembler_arm64.h...
> runtime/vm/assembler_arm64.h:1675: void
EmitCompareAndBranch(CompareAndBranchOp
> op, Register rt,
> You also need to detect these instructions in Bind in assembler_arm64.cc and
> make the right fixups.

Good point!
PTAL

[regis, 2014-11-07 17:01:45]

On 2014/11/06 18:43:51, regis wrote:
> On 2014/11/06 00:30:59, zra wrote:
> >
https://codereview.chromium.org/701233003/diff/1/runtime/vm/assembler_arm64.h
> > File runtime/vm/assembler_arm64.h (right):
> > 
> >
>
https://codereview.chromium.org/701233003/diff/1/runtime/vm/assembler_arm64.h...
> > runtime/vm/assembler_arm64.h:1675: void
> EmitCompareAndBranch(CompareAndBranchOp
> > op, Register rt,
> > You also need to detect these instructions in Bind in assembler_arm64.cc and
> > make the right fixups.
> 
> Good point!
> PTAL

friendly ping

[zra, 2014-11-07 17:02:16]

lgtm

[regis, 2014-11-07 17:19:36]

Thanks!

[regis, 2014-11-07 17:19:50]

Committed patchset #3 (id:40001) manually as r41608 (presubmit successful).

[zra, 2014-11-07 23:22:11]

I verified that the new assembler tests and the RSA benchmark are working on
hardware.

[regis, 2014-11-07 23:29:28]

Thanks for verifying!