Improve type propagation for AssertAssignable.

Improve type propagation for AssertAssignable.

Updating the type of the incoming definition during
type propagation like we do for CheckClass, CheckSmi, etc.

This helps if the original definition is used instead of the
redefined value.

We also can get rid of storing back every local variable
at function start in unoptimized code in checked mode.

R=vegorov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41638

[Florian Schneider, 2014-11-10 14:24:04]

fschneider@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2014-11-10 15:52:01]

lgtm

ove

https://codereview.chromium.org/700843005/diff/20001/runtime/vm/flow_graph_ty...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/700843005/diff/20001/runtime/vm/flow_graph_ty...
runtime/vm/flow_graph_type_propagator.cc:779: void
FlowGraphTypePropagator::VisitAssertAssignable(
Move it together with other methods.

Maybe also define it in terms of AssertAssignable::ComputeType?

SetTypeOf(instr->value()->definition(), instr->ComputeType())

?

[Florian Schneider, 2014-11-10 16:18:46]

https://codereview.chromium.org/700843005/diff/20001/runtime/vm/flow_graph_ty...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/700843005/diff/20001/runtime/vm/flow_graph_ty...
runtime/vm/flow_graph_type_propagator.cc:779: void
FlowGraphTypePropagator::VisitAssertAssignable(
On 2014/11/10 15:52:01, Vyacheslav Egorov (Google) wrote:
> Move it together with other methods.
> 
> Maybe also define it in terms of AssertAssignable::ComputeType?
> 
> SetTypeOf(instr->value()->definition(), instr->ComputeType())
> 
> ?

Done.

[Florian Schneider, 2014-11-10 16:25:54]

Committed patchset #3 (id:40001) manually as r41638 (presubmit successful).