Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2358)

Unified Diff: runtime/vm/flow_graph_builder.cc

Issue 700843005: Improve type propagation for AssertAssignable. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_type_propagator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_builder.cc
===================================================================
--- runtime/vm/flow_graph_builder.cc (revision 41629)
+++ runtime/vm/flow_graph_builder.cc (working copy)
@@ -3784,16 +3784,10 @@
parameter.type(),
parameter.name())) {
Value* parameter_value = Bind(BuildLoadLocal(parameter));
- AssertAssignableInstr* assert_assignable =
- BuildAssertAssignable(parameter.token_pos(),
- parameter_value,
- parameter.type(),
- parameter.name());
- parameter_value = Bind(assert_assignable);
- // Store the type checked argument back to its corresponding local
- // variable so that ssa renaming detects the dependency and makes use
- // of the checked type in type propagation.
- Do(BuildStoreLocal(parameter, parameter_value));
+ Do(BuildAssertAssignable(parameter.token_pos(),
+ parameter_value,
+ parameter.type(),
+ parameter.name()));
}
pos++;
}
« no previous file with comments | « no previous file | runtime/vm/flow_graph_type_propagator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698