Issue 700753002: Split the largest classes from resolver.dart to their own files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 700753002: Split the largest classes from resolver.dart to their own files. (Closed)

Created:
6 years, 1 month ago by Paul Berry

Modified:
6 years, 1 month ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Split the largest classes from resolver.dart to their own files. This should make resolver.dart small enough to support side-by-side diffs in the code review tool. R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41489

Created: 6 years, 1 month ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+9865 lines, -0 lines)			Patch
A	pkg/analyzer/lib/src/generated/element_resolver.dart	View	1 chunk	+2637 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/engine.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	pkg/analyzer/lib/src/generated/error_verifier.dart	View	1 chunk	+5498 lines, -0 lines	0 comments	Download
A	pkg/analyzer/lib/src/generated/static_type_analyzer.dart	View	1 chunk	+1727 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/resolver_test.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

Note: because of resolver.dart's large size, the code review tool didn't upload the patch for ...

6 years, 1 month ago (2014-11-04 05:23:49 UTC) #2

Paul Berry

6 years, 1 month ago (2014-11-04 14:04:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41489 (presubmit successful).