Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 698563005: Support parsing of enums in dart2js. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add unparser test. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/implementation/scanner/keyword.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/listener.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/scanner/parser.dart View 2 chunks +24 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/nodes.dart View 3 chunks +29 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/prettyprint.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/tree/unparser.dart View 1 chunk +7 lines, -0 lines 2 comments Download
M tests/compiler/dart2js/unparser2_test.dart View 1 2 chunks +31 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-11-04 13:42:00 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/698563005/diff/20001/sdk/lib/_internal/compiler/implementation/tree/unparser.dart File sdk/lib/_internal/compiler/implementation/tree/unparser.dart (right): https://codereview.chromium.org/698563005/diff/20001/sdk/lib/_internal/compiler/implementation/tree/unparser.dart#newcode129 sdk/lib/_internal/compiler/implementation/tree/unparser.dart:129: visit(node.name); Why don't we need "{" and "}" ...
6 years, 1 month ago (2014-11-06 12:41:58 UTC) #3
Johnni Winther
https://codereview.chromium.org/698563005/diff/20001/sdk/lib/_internal/compiler/implementation/tree/unparser.dart File sdk/lib/_internal/compiler/implementation/tree/unparser.dart (right): https://codereview.chromium.org/698563005/diff/20001/sdk/lib/_internal/compiler/implementation/tree/unparser.dart#newcode129 sdk/lib/_internal/compiler/implementation/tree/unparser.dart:129: visit(node.name); On 2014/11/06 12:41:58, floitsch wrote: > Why don't ...
6 years, 1 month ago (2014-11-06 12:49:41 UTC) #4
Johnni Winther
6 years, 1 month ago (2014-11-07 09:35:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41595 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698