Issue 282453004: Dart2js enum parsing.

Created:
6 years, 7 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Patch Set 3 : Allow trailing comma. #

Total comments: 2

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -0 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/scanner/keyword.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/listener.dart	View		2 chunks	+12 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/scanner/parser.dart	View	1 2	2 chunks	+24 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree/nodes.dart	View	1	3 chunks	+29 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree/prettyprint.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/tree/unparser.dart	View	1 2	1 chunk	+7 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

https://codereview.chromium.org/282453004/diff/1/sdk/lib/_internal/compiler/implementation/tree/nodes.dart File sdk/lib/_internal/compiler/implementation/tree/nodes.dart (right): https://codereview.chromium.org/282453004/diff/1/sdk/lib/_internal/compiler/implementation/tree/nodes.dart#newcode1851 sdk/lib/_internal/compiler/implementation/tree/nodes.dart:1851: visitChcildren(Visitor visitor) { visitChildren

6 years, 7 months ago (2014-05-12 09:51:11 UTC) #1

ahe

https://codereview.chromium.org/282453004/diff/20001/sdk/lib/_internal/compiler/implementation/scanner/parser.dart File sdk/lib/_internal/compiler/implementation/scanner/parser.dart (right): https://codereview.chromium.org/282453004/diff/20001/sdk/lib/_internal/compiler/implementation/scanner/parser.dart#newcode459 sdk/lib/_internal/compiler/implementation/scanner/parser.dart:459: Token parseEnum(Token token) { This looks reasonable. I think ...

6 years, 7 months ago (2014-05-12 11:24:02 UTC) #2

floitsch

LGTM. https://codereview.chromium.org/282453004/diff/40001/sdk/lib/_internal/compiler/implementation/tree/unparser.dart File sdk/lib/_internal/compiler/implementation/tree/unparser.dart (right): https://codereview.chromium.org/282453004/diff/40001/sdk/lib/_internal/compiler/implementation/tree/unparser.dart#newcode79 sdk/lib/_internal/compiler/implementation/tree/unparser.dart:79: sb.write(' '); why don't you need to write ...

6 years, 1 month ago (2014-11-04 14:06:51 UTC) #3

Lasse Reichstein Nielsen

6 years, 1 month ago (2014-11-06 13:24:52 UTC) #4

https://codereview.chromium.org/282453004/diff/40001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/tree/unparser.dart (right):

https://codereview.chromium.org/282453004/diff/40001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/tree/unparser.dart:79: sb.write(' ');
On 2014/11/04 14:06:51, floitsch wrote:
> why don't you need to write the "{" and "}"?

The NodeList knows about delimiters, '{', '}' and ','.

Expand Messages | Collapse Messages