Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 695773003: move import combinator suggestions into a separate computer (Closed)

Created:
6 years, 1 month ago by danrubel
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

move import combinator suggestions into a separate computer BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41442

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -100 lines) Patch
A pkg/analysis_server/lib/src/services/completion/combinator_computer.dart View 1 chunk +70 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/dart_completion_manager.dart View 3 chunks +3 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/services/completion/imported_computer.dart View 2 chunks +0 lines, -18 lines 0 comments Download
A pkg/analysis_server/test/services/completion/combinator_computer_test.dart View 1 chunk +155 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 4 chunks +19 lines, -81 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 1 month ago (2014-10-31 18:23:54 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-10-31 18:27:39 UTC) #3
danrubel
6 years, 1 month ago (2014-10-31 18:31:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41442 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698