Issue 21498. Fix for navigation from instance creation with type arguments.

Issue 21498. Fix for navigation from instance creation with type arguments.

R=paulberry@google.com
BUG= https://code.google.com/p/dart/issues/detail?id=21498

Committed: https://code.google.com/p/dart/source/detail?r=41468

[Paul Berry, 2014-11-03 20:35:13]

lgtm once comment below is addressed.

https://codereview.chromium.org/694383003/diff/1/pkg/analysis_server/test/ana...
File pkg/analysis_server/test/analysis/notification_navigation_test.dart
(right):

https://codereview.chromium.org/694383003/diff/1/pkg/analysis_server/test/ana...
pkg/analysis_server/test/analysis/notification_navigation_test.dart:315: class
B<T> {
Rather than modifying these tests to use generic arguments, I'd recommend
leaving the tests as is and adding additional tests to verify that navigation
works correctly when template arguments are in use.

Otherwise we run the risk of regression the non-generic-argument case.

[scheglov, 2014-11-03 20:45:36]

https://codereview.chromium.org/694383003/diff/1/pkg/analysis_server/test/ana...
File pkg/analysis_server/test/analysis/notification_navigation_test.dart
(right):

https://codereview.chromium.org/694383003/diff/1/pkg/analysis_server/test/ana...
pkg/analysis_server/test/analysis/notification_navigation_test.dart:315: class
B<T> {
On 2014/11/03 20:35:13, Paul Berry wrote:
> Rather than modifying these tests to use generic arguments, I'd recommend
> leaving the tests as is and adding additional tests to verify that navigation
> works correctly when template arguments are in use.
> 
> Otherwise we run the risk of regression the non-generic-argument case.

Yes, I was not sure if it worth to keep non-generic tests or just change them.
It seems that we want to have both.
Done.

[scheglov, 2014-11-03 20:45:41]

Committed patchset #2 (id:20001) manually as 41468 (presubmit successful).