Only lower-case ContentType's values if the name is 'charset'.

Only lower-case ContentType's values if the name is 'charset'.

BUG=https://code.google.com/p/dart/issues/detail?id=21385
R=lrn@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41456

[Anders Johnsen, 2014-11-03 10:45:33]

ajohnsen@google.com changed reviewers:
+ lrn@google.com, sgjesse@google.com

[Søren Gjesse, 2014-11-03 10:47:27]

LGTM, thanks

[Lasse Reichstein Nielsen, 2014-11-03 10:51:17]

lgtm

https://codereview.chromium.org/694293002/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/694293002/diff/1/sdk/lib/io/http.dart#newcode755
sdk/lib/io/http.dart:755: * converted to lower case, only if the parameter name
is 'charset'.
Change last sentence to:
"The `charset` entry, whether passed as `charset` or in `parameters`, will have
its value converted to lower-case."

Talking about "Values ... will be converted ... only if (single case)" makes the
plurality of "Values" sound odd.

[Anders Johnsen, 2014-11-03 12:34:14]

Committed patchset #2 (id:20001) manually as 41456 (presubmit successful).

[Anders Johnsen, 2014-11-03 12:38:29]

https://codereview.chromium.org/694293002/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/694293002/diff/1/sdk/lib/io/http.dart#newcode755
sdk/lib/io/http.dart:755: * converted to lower case, only if the parameter name
is 'charset'.
On 2014/11/03 10:51:17, Lasse Reichstein Nielsen wrote:
> Change last sentence to:
> "The `charset` entry, whether passed as `charset` or in `parameters`, will
have
> its value converted to lower-case."
> 
> Talking about "Values ... will be converted ... only if (single case)" makes
the
> plurality of "Values" sound odd.

Done.