Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Unified Diff: sdk/lib/io/http_headers.dart

Issue 694293002: Only lower-case ContentType's values if the name is 'charset'. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/io/http.dart ('k') | tests/standalone/io/http_headers_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/io/http_headers.dart
diff --git a/sdk/lib/io/http_headers.dart b/sdk/lib/io/http_headers.dart
index 5ecddca1b1bcfaf01ff1de5c8b00a0a8459dfb4b..47001282fce35a26c2eba1d4b7bfc8f3e1bc419a 100644
--- a/sdk/lib/io/http_headers.dart
+++ b/sdk/lib/io/http_headers.dart
@@ -747,6 +747,10 @@ class _HeaderValue implements HeaderValue {
expect("=");
skipWS();
String value = parseParameterValue();
+ if (name == 'charset' && this is _ContentType) {
+ // Charset parameter of ContentTypes are always lower-case.
+ value = value.toLowerCase();
+ }
parameters[name] = value;
skipWS();
if (done()) return;
@@ -779,7 +783,11 @@ class _ContentType extends _HeaderValue implements ContentType {
if (parameters != null) {
_ensureParameters();
parameters.forEach((String key, String value) {
- this._parameters[key.toLowerCase()] = value.toLowerCase();
+ String lowerCaseKey = key.toLowerCase();
+ if (lowerCaseKey == "charset") {
+ value = value.toLowerCase();
+ }
+ this._parameters[lowerCaseKey] = value;
});
}
if (charset != null) {
« no previous file with comments | « sdk/lib/io/http.dart ('k') | tests/standalone/io/http_headers_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698