Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 693803003: Move continueWithExpression to IrBuilder. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move continueWithExpression to IrBuilder. + cleanup of invocations + prepare analyzer2dart support for type operators R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41435

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -149 lines) Patch
M sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart View 6 chunks +159 lines, -68 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart View 10 chunks +31 lines, -56 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart View 1 1 chunk +9 lines, -6 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes_sexpr.dart View 4 chunks +11 lines, -11 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/backend_ast_to_frontend_ast.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/dart_backend/tree_ir_nodes.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/use_unused_api.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-10-31 10:14:03 UTC) #2
sigurdm
lgtm https://codereview.chromium.org/693803003/diff/1/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart (right): https://codereview.chromium.org/693803003/diff/1/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart#newcode286 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart:286: final bool isTypeTest; add todo: add operator getter.
6 years, 1 month ago (2014-10-31 11:47:46 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 41435 (presubmit successful).
6 years, 1 month ago (2014-10-31 12:05:11 UTC) #4
Johnni Winther
6 years, 1 month ago (2014-10-31 14:12:13 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/693803003/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart (right):

https://codereview.chromium.org/693803003/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart:286: final
bool isTypeTest;
On 2014/10/31 11:47:46, sigurdm wrote:
> add todo: add operator getter.

Done.

Powered by Google App Engine
This is Rietveld 408576698