Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Side by Side Diff: sdk/lib/_internal/compiler/implementation/cps_ir/constant_propagation.dart

Issue 693803003: Move continueWithExpression to IrBuilder. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of dart2js.optimizers; 5 part of dart2js.optimizers;
6 6
7 /** 7 /**
8 * Propagates constants throughout the IR, and replaces branches with fixed 8 * Propagates constants throughout the IR, and replaces branches with fixed
9 * jumps as well as side-effect free expressions with known constant results. 9 * jumps as well as side-effect free expressions with known constant results.
10 * Should be followed by the [ShrinkingReducer] pass. 10 * Should be followed by the [ShrinkingReducer] pass.
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
485 void visitTypeOperator(TypeOperator node) { 485 void visitTypeOperator(TypeOperator node) {
486 Continuation cont = node.continuation.definition; 486 Continuation cont = node.continuation.definition;
487 setReachable(cont); 487 setReachable(cont);
488 488
489 void setValues(_ConstnessLattice updateValue) { 489 void setValues(_ConstnessLattice updateValue) {
490 setValue(node, updateValue); 490 setValue(node, updateValue);
491 Parameter returnValue = cont.parameters[0]; 491 Parameter returnValue = cont.parameters[0];
492 setValue(returnValue, updateValue); 492 setValue(returnValue, updateValue);
493 } 493 }
494 494
495 if (node.operator != "is") { 495 if (node.isTypeCast) {
496 // TODO(jgruber): Add support for `as` casts. 496 // TODO(jgruber): Add support for `as` casts.
497 setValues(_ConstnessLattice.NonConst); 497 setValues(_ConstnessLattice.NonConst);
498 } 498 }
499 499
500 _ConstnessLattice cell = getValue(node.receiver.definition); 500 _ConstnessLattice cell = getValue(node.receiver.definition);
501 if (cell.isUnknown) { 501 if (cell.isUnknown) {
502 return; // And come back later. 502 return; // And come back later.
503 } else if (cell.isNonConst) { 503 } else if (cell.isNonConst) {
504 setValues(_ConstnessLattice.NonConst); 504 setValues(_ConstnessLattice.NonConst);
505 } else if (node.type.kind == types.TypeKind.INTERFACE) { 505 } else if (node.type.kind == types.TypeKind.INTERFACE) {
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
657 return that; 657 return that;
658 } 658 }
659 659
660 if (this.constant == that.constant) { 660 if (this.constant == that.constant) {
661 return this; 661 return this;
662 } 662 }
663 663
664 return NonConst; 664 return NonConst;
665 } 665 }
666 } 666 }
OLDNEW
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698