Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 692753004: Generate docgen information with dart: names rather than dart- or dart-dom- (Closed)

Created:
6 years, 1 month ago by Alan Knight
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Generate docgen information with dart: names rather than dart- or dart-dom- BUG= R=kathyw@google.com, sethladd@google.com Committed: https://code.google.com/p/dart/source/detail?r=41577

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M pkg/docgen/lib/src/models/model_helpers.dart View 1 chunk +10 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Alan Knight
6 years, 1 month ago (2014-11-05 23:35:13 UTC) #2
Kathy Walrath
lgtm Looks great to me, but I'd want Seth to do a real code review.
6 years, 1 month ago (2014-11-05 23:43:39 UTC) #3
Alan Knight
Seth?
6 years, 1 month ago (2014-11-06 18:10:50 UTC) #4
sethladd
lgtm
6 years, 1 month ago (2014-11-06 18:16:28 UTC) #5
Alan Knight
Committed patchset #1 (id:1) manually as 41577 (presubmit successful).
6 years, 1 month ago (2014-11-06 18:36:42 UTC) #6
Johnni Winther
This breaks docgen on Windows since the filename used for dart:core entities contain a ':'.
6 years, 1 month ago (2014-11-10 11:24:12 UTC) #8
Kathy Walrath
On 2014/11/10 11:24:12, Johnni Winther wrote: > This breaks docgen on Windows since the filename ...
6 years, 1 month ago (2014-11-10 15:57:10 UTC) #9
Alan Knight
Oops. Of course it does.
6 years, 1 month ago (2014-11-10 17:37:34 UTC) #10
Alan Knight
6 years, 1 month ago (2014-11-10 23:13:41 UTC) #11
Message was sent while issue was closed.
https://codereview.chromium.org//713863003
and
https://codereview.chromium.org/695593003/

should have fixed this now. And fortunately things with dart: in the name never
got out of bleeding edge.

Powered by Google App Engine
This is Rietveld 408576698