Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 713863003: Generate docgen file names with hyphens in their names instead of colons (Closed)

Created:
6 years, 1 month ago by Alan Knight
Modified:
6 years, 1 month ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org, ricow1, Kathy Walrath
Visibility:
Public.

Description

Generate docgen file names with hyphens in their names instead of colons BUG= R=kevmoo@google.com Committed: https://code.google.com/p/dart/source/detail?r=41642

Patch Set 1 #

Patch Set 2 : Fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M pkg/docgen/lib/src/generator.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/docgen/lib/src/models/indexable.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/docgen/test/inherited_comments_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
6 years, 1 month ago (2014-11-10 18:13:41 UTC) #2
kevmoo
LGTM
6 years, 1 month ago (2014-11-10 18:23:06 UTC) #3
Alan Knight
6 years, 1 month ago (2014-11-10 18:25:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41642 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698