display completion performance in new server status page

display completion performance in new server status page

BUG=
R=scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41612

[danrubel, 2014-11-07 17:22:10]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2014-11-07 17:29:37]

LGTM

https://codereview.chromium.org/691853006/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/completion_manager.dart
(right):

https://codereview.chromium.org/691853006/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/completion_manager.dart:97:
return result;
Do we use these values somewhere?

[danrubel, 2014-11-07 18:09:46]

https://codereview.chromium.org/691853006/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/services/completion/completion_manager.dart
(right):

https://codereview.chromium.org/691853006/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/services/completion/completion_manager.dart:97:
return result;
On 2014/11/07 17:29:37, scheglov wrote:
> Do we use these values somewhere?

Yes. In several places, logElapseTime is called with a function as the second
argument, and the return value from that function is passed to the caller and
used at the logElapseTime call site.

[danrubel, 2014-11-07 18:10:59]

Committed patchset #2 (id:20001) manually as 41612 (presubmit successful).