Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: pkg/analysis_server/lib/src/domain_completion.dart

Issue 691853006: display completion performance in new server status page (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/get_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domain_completion.dart
diff --git a/pkg/analysis_server/lib/src/domain_completion.dart b/pkg/analysis_server/lib/src/domain_completion.dart
index f70a1e9c92650c412d128a715566cd638e2e3559..cdda8f2eee631923920335a0d728b29ad19a9889 100644
--- a/pkg/analysis_server/lib/src/domain_completion.dart
+++ b/pkg/analysis_server/lib/src/domain_completion.dart
@@ -25,6 +25,11 @@ class CompletionDomainHandler implements RequestHandler {
int _nextCompletionId = 0;
/**
+ * Code completion peformance for the last completion operation.
+ */
+ CompletionPerformance performance;
+
+ /**
* Initialize a new request handler for the given [server].
*/
CompletionDomainHandler(this.server);
@@ -46,25 +51,31 @@ class CompletionDomainHandler implements RequestHandler {
* Process a `completion.getSuggestions` request.
*/
Response processRequest(Request request) {
+ performance = new CompletionPerformance();
// extract params
- var params = new CompletionGetSuggestionsParams.fromRequest(request);
+ CompletionGetSuggestionsParams params =
+ new CompletionGetSuggestionsParams.fromRequest(request);
// schedule completion analysis
String completionId = (_nextCompletionId++).toString();
CompletionManager.create(
server.getAnalysisContext(params.file),
server.getSource(params.file),
params.offset,
- server.searchEngine).results().listen((CompletionResult result) {
+ server.searchEngine,
+ performance).results().listen((CompletionResult result) {
sendCompletionNotification(
completionId,
result.replacementOffset,
result.replacementLength,
result.suggestions,
result.last);
+ if (result.last) {
+ performance.complete();
+ }
});
// initial response without results
- return new CompletionGetSuggestionsResult(completionId).toResponse(
- request.id);
+ return new CompletionGetSuggestionsResult(
+ completionId).toResponse(request.id);
}
/**
@@ -72,7 +83,12 @@ class CompletionDomainHandler implements RequestHandler {
*/
void sendCompletionNotification(String completionId, int replacementOffset,
int replacementLength, Iterable<CompletionSuggestion> results, bool isLast) {
- server.sendNotification(new CompletionResultsParams(completionId,
- replacementOffset, replacementLength, results, isLast).toNotification());
+ server.sendNotification(
+ new CompletionResultsParams(
+ completionId,
+ replacementOffset,
+ replacementLength,
+ results,
+ isLast).toNotification());
}
}
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/get_handler.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698