Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 690353002: Fix for 'Replace if-else with conditional expression' in case of mixed expression/return branches. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix for 'Replace if-else with conditional expression' in case of mixed expression/return branches. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 3 chunks +26 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-10-31 19:11:01 UTC) #1
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-10-31 19:16:11 UTC) #2
scheglov
6 years, 1 month ago (2014-10-31 19:22:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41446 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698