pkg/analysis_server/lib/src/services/correction/assist_internal.dart - Issue 690353002: Fix for 'Replace if-else with conditional expression' in case of mixed expression/return branches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

Issue 690353002: Fix for 'Replace if-else with conditional expression' in case of mixed expression/return branches. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/analysis_server/lib/src/services/correction/assist_internal.dart

diff --git a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

index 177461db6e30ba724b0a4f701653b4f0f375280f..2034c5431992a63811702eaef18392abab0ec19c 100644

--- a/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

+++ b/pkg/analysis_server/lib/src/services/correction/assist_internal.dart

@@ -1129,7 +1129,7 @@ class AssistProcessor {

return;

}

// returns

- if (thenStatement is ReturnStatement || elseStatement is ReturnStatement) {

+ if (thenStatement is ReturnStatement && elseStatement is ReturnStatement) {

ReturnStatement thenReturn = thenStatement as ReturnStatement;

ReturnStatement elseReturn = elseStatement as ReturnStatement;

String conditionSrc = _getNodeText(ifStatement.condition);

« no previous file with comments | « no previous file | pkg/analysis_server/test/services/correction/assist_test.dart » ('j') | no next file with comments »