Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 685583002: Add more missing StorePointer/StoreSmi calls. (Closed)

Created:
6 years, 1 month ago by koda
Modified:
6 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add more missing StorePointer/StoreSmi calls. Also move these to RawObject (as privates), for when handles are unavailable. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41609

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -48 lines) Patch
M runtime/vm/gc_marker.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M runtime/vm/object.h View 4 chunks +8 lines, -36 lines 0 comments Download
M runtime/vm/object.cc View 1 4 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 5 chunks +36 lines, -1 line 0 comments Download
M runtime/vm/snapshot.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
koda
6 years, 1 month ago (2014-10-27 22:26:16 UTC) #1
Ivan Posva
https://codereview.chromium.org/685583002/diff/20001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://codereview.chromium.org/685583002/diff/20001/runtime/vm/raw_object.h#newcode482 runtime/vm/raw_object.h:482: // Start of field mutator guards. Please remove superfluous ...
6 years, 1 month ago (2014-10-29 06:17:34 UTC) #2
koda
https://codereview.chromium.org/685583002/diff/20001/runtime/vm/raw_object.h File runtime/vm/raw_object.h (right): https://codereview.chromium.org/685583002/diff/20001/runtime/vm/raw_object.h#newcode482 runtime/vm/raw_object.h:482: // Start of field mutator guards. On 2014/10/29 06:17:34, ...
6 years, 1 month ago (2014-10-29 19:30:16 UTC) #3
koda
On 2014/10/29 19:30:16, koda wrote: > https://codereview.chromium.org/685583002/diff/20001/runtime/vm/raw_object.h > File runtime/vm/raw_object.h (right): > > https://codereview.chromium.org/685583002/diff/20001/runtime/vm/raw_object.h#newcode482 > ...
6 years, 1 month ago (2014-11-05 23:02:03 UTC) #4
Ivan Posva
LGTM -ip
6 years, 1 month ago (2014-11-07 17:23:02 UTC) #5
koda
6 years, 1 month ago (2014-11-07 17:24:52 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as r41609 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698