Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: runtime/vm/gc_marker.cc

Issue 685583002: Add more missing StorePointer/StoreSmi calls. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/gc_marker.cc
===================================================================
--- runtime/vm/gc_marker.cc (revision 41331)
+++ runtime/vm/gc_marker.cc (working copy)
@@ -246,9 +246,10 @@
// after skipping the function's code pointer, then we disconnect the
// code from the function.
StubCode* stub_code = isolate()->stub_code();
- func->ptr()->instructions_ =
- stub_code->LazyCompile_entry()->code()->ptr()->instructions_;
- func->ptr()->unoptimized_code_ = Code::null();
+ func->StorePointer(
+ &(func->ptr()->instructions_),
+ stub_code->LazyCompile_entry()->code()->ptr()->instructions_);
+ func->StorePointer(&(func->ptr()->unoptimized_code_), Code::null());
if (FLAG_log_code_drop) {
// NOTE: This code runs while GC is in progress and runs within
// a NoHandleScope block. Hence it is not okay to use a regular Zone
« no previous file with comments | « no previous file | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698