Inline JUnitTestCase 'assert' methods.

Inline JUnitTestCase 'assert' methods.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=41347

[Brian Wilkerson, 2014-10-27 23:13:29]

LGTM in theory. I looked at the first two files, the last two files, and part of
the third, but didn't verify the rest of the changes.

https://codereview.chromium.org/685573002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/test_support.dart (right):

https://codereview.chromium.org/685573002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/test_support.dart:177: expect(false, isTrue, reason:
"Content not as expected: is 'null' expected: $expected");
Why not just use 'fail'?

https://codereview.chromium.org/685573002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/utilities_test.dart (right):

https://codereview.chromium.org/685573002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/utilities_test.dart:2107: expect(BooleanArray.get(0,
0), false);
Should these be isFalse and isTrue? When should we use a matcher rather than a
concrete value?

https://codereview.chromium.org/685573002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/utilities_test.dart:2264: expect(cycle[0], node);
When should we use a matcher like "equals(node)" rather than just "node"?

[scheglov, 2014-10-28 00:00:25]

Committed patchset #1 (id:1) manually as 41347 (presubmit successful).

[scheglov, 2014-10-28 00:01:06]

https://codereview.chromium.org/685573002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/test_support.dart (right):

https://codereview.chromium.org/685573002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/test_support.dart:177: expect(false, isTrue, reason:
"Content not as expected: is 'null' expected: $expected");
On 2014/10/27 23:13:29, Brian Wilkerson wrote:
> Why not just use 'fail'?

The original Java source:

Assert.assertTrue("Content not as expected: is 'null' expected: " + expected,
false);

Fixed.

https://codereview.chromium.org/685573002/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/utilities_test.dart (right):

https://codereview.chromium.org/685573002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/utilities_test.dart:2107: expect(BooleanArray.get(0,
0), false);
On 2014/10/27 23:13:29, Brian Wilkerson wrote:
> Should these be isFalse and isTrue? When should we use a matcher rather than a
> concrete value?

The original Java source:

assertEquals(false, BooleanArray.get(0, 0));

I guess we can rewrite these expect invocations into isTrue or isFalse.

https://codereview.chromium.org/685573002/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/utilities_test.dart:2264: expect(cycle[0], node);
On 2014/10/27 23:13:29, Brian Wilkerson wrote:
> When should we use a matcher like "equals(node)" rather than just "node"?

expect() automatically wraps its expected value into equals(), so we leave it
out for simplicity.