Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: pkg/analyzer/test/generated/static_warning_code_test.dart

Issue 685573002: Inline JUnitTestCase 'assert' methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/test/generated/static_warning_code_test.dart
diff --git a/pkg/analyzer/test/generated/static_warning_code_test.dart b/pkg/analyzer/test/generated/static_warning_code_test.dart
index 8c4083f5d6ce4581740c50f3569c582a52c63250..d4333db39e0f784290acff6acbc871deac566ae6 100644
--- a/pkg/analyzer/test/generated/static_warning_code_test.dart
+++ b/pkg/analyzer/test/generated/static_warning_code_test.dart
@@ -4,11 +4,10 @@
library engine.static_warning_code_test;
-import 'package:analyzer/src/generated/java_junit.dart';
import 'package:analyzer/src/generated/source_io.dart';
import 'package:analyzer/src/generated/error.dart';
import 'package:analyzer/src/generated/parser.dart' show ParserErrorCode;
-import 'package:unittest/unittest.dart' as _ut;
+import 'package:unittest/unittest.dart';
import 'resolver_test.dart';
import 'test_support.dart';
import '../reflective_tests.dart';
@@ -274,11 +273,11 @@ g(h(_A a)) {}''');
List<AnalysisError> errors = analysisContext2.computeErrors(source);
EngineTestCase.assertLength(1, errors);
AnalysisError error = errors[0];
- JUnitTestCase.assertEquals(error.errorCode, StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE);
+ expect(StaticWarningCode.ARGUMENT_TYPE_NOT_ASSIGNABLE, error.errorCode);
String message = error.message;
- JUnitTestCase.assertTrue(message.indexOf("_A") != -1);
- JUnitTestCase.assertTrue(message.indexOf("lib1.dart") != -1);
- JUnitTestCase.assertTrue(message.indexOf("lib2.dart") != -1);
+ expect(message.indexOf("_A") != -1, isTrue);
+ expect(message.indexOf("lib1.dart") != -1, isTrue);
+ expect(message.indexOf("lib2.dart") != -1, isTrue);
}
void test_argumentTypeNotAssignable_annotation_namedConstructor() {
@@ -3143,6 +3142,6 @@ class S {
}
main() {
- _ut.groupSep = ' | ';
+ groupSep = ' | ';
runReflectiveTests(StaticWarningCodeTest);
}

Powered by Google App Engine
This is Rietveld 408576698