Be sure we don't forward an error to a closed event stream.

Be sure we don't forward an error to a closed event stream.

R=rnystrom@google.com
BUG=15034
Committed: https://code.google.com/p/dart/source/detail?r=30210

[nweiz, 2013-11-12 20:59:51]

It's hard to tell exactly what's causing issue 15034 because of the lack of
stack trace information, but this looks like the only place in the watcher code
where [addError] could even plausibly be called on a closed stream.

[Bob Nystrom, 2013-11-12 21:31:06]

https://codereview.chromium.org/68253010/diff/50001/pkg/watcher/lib/src/async...
File pkg/watcher/lib/src/async_queue.dart (left):

https://codereview.chromium.org/68253010/diff/50001/pkg/watcher/lib/src/async...
pkg/watcher/lib/src/async_queue.dart:11: typedef void ErrorHandler(error);
Why remove this typedef?

[nweiz, 2013-11-12 21:54:29]

https://codereview.chromium.org/68253010/diff/50001/pkg/watcher/lib/src/async...
File pkg/watcher/lib/src/async_queue.dart (left):

https://codereview.chromium.org/68253010/diff/50001/pkg/watcher/lib/src/async...
pkg/watcher/lib/src/async_queue.dart:11: typedef void ErrorHandler(error);
On 2013/11/12 21:31:07, Bob Nystrom wrote:
> Why remove this typedef?

dart:async now accepts either fn(error) or fn(error, stackTrace), and typedefing
as fn(error, [stackTrace]) apparently doesn't work.

[Bob Nystrom, 2013-11-12 21:55:55]

LGTM.

[nweiz, 2013-11-12 22:19:28]

Committed patchset #2 manually as r30210 (presubmit successful).