pkg/watcher/lib/src/async_queue.dart - Issue 68253010: Be sure we don't forward an error to a closed event stream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/watcher/lib/src/async_queue.dart

Issue 68253010: Be sure we don't forward an error to a closed event stream. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Un-mark the test as flaky Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pkg/watcher/lib/src/async_queue.dart

diff --git a/pkg/watcher/lib/src/async_queue.dart b/pkg/watcher/lib/src/async_queue.dart

index 9456631af12107687e6ca899a47a4d732210581f..8ac0cdfe1c031dbd3aedb13dcf87ceb31d7a552e 100644

--- a/pkg/watcher/lib/src/async_queue.dart

+++ b/pkg/watcher/lib/src/async_queue.dart

@@ -8,7 +8,6 @@ import 'dart:async';

import 'dart:collection';

typedef Future ItemProcessor<T>(T item);

-typedef void ErrorHandler(error);

Bob Nystrom 2013/11/12 21:31:07 Why remove this typedef?

nweiz 2013/11/12 21:54:29 dart:async now accepts either fn(error) or fn(erro

/// A queue of items that are sequentially, asynchronously processed.

///

@@ -35,9 +34,9 @@ class AsyncQueue<T> {

/// The handler for errors thrown during processing.

///

/// Used to avoid top-leveling asynchronous errors.

- final ErrorHandler _errorHandler;

+ final Function _errorHandler;

- AsyncQueue(this._processor, {ErrorHandler onError})

+ AsyncQueue(this._processor, {Function onError})

: _errorHandler = onError;

/// Enqueues [item] to be processed and starts asynchronously processing it

« no previous file with comments | « pkg/pkg.status ('k') | pkg/watcher/lib/src/directory_watcher/polling.dart » ('j') | no next file with comments »