Filter frames from debugger stack based on visibility rather than "debuggability" (steppability).

Filter frames from debugger stack based on visibility rather than "debuggability" (steppability).

R=asiva@google.com, hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30280

[hausner, 2013-11-13 23:05:26]

I like this change a lot. LGTM.

https://codereview.chromium.org/68113019/diff/30001/tests/standalone/vmservic...
File tests/standalone/vmservice/isolate_stacktrace_command_test.dart (right):

https://codereview.chromium.org/68113019/diff/30001/tests/standalone/vmservic...
tests/standalone/vmservice/isolate_stacktrace_command_test.dart:16:
Expect.isTrue(4 <= reply['members'].length, 'Stacktrace is wrong length.');
What else did you see in the trace? Is it a function that should be invisible?

[rmacnak, 2013-11-13 23:12:08]

On 2013/11/13 23:05:26, hausner wrote:
> I like this change a lot. LGTM.
> 
>
https://codereview.chromium.org/68113019/diff/30001/tests/standalone/vmservic...
> File tests/standalone/vmservice/isolate_stacktrace_command_test.dart (right):
> 
>
https://codereview.chromium.org/68113019/diff/30001/tests/standalone/vmservic...
> tests/standalone/vmservice/isolate_stacktrace_command_test.dart:16:
> Expect.isTrue(4 <= reply['members'].length, 'Stacktrace is wrong length.');
> What else did you see in the trace? Is it a function that should be invisible?

a
b
c
myIsolateName
isolateStartHandler
_handleMessage

The bottom two are non-patch Dart functions with source in isolate_patch.dart.

[rmacnak, 2013-11-13 23:14:34]

https://codereview.chromium.org/68113019/diff/30001/tests/standalone/vmservic...
File tests/standalone/vmservice/isolate_stacktrace_command_test.dart (right):

https://codereview.chromium.org/68113019/diff/30001/tests/standalone/vmservic...
tests/standalone/vmservice/isolate_stacktrace_command_test.dart:17: // The
number of frames involved in isolate start-up is an implementation
So actually this should be "message dispatch" not "start-up".

[siva, 2013-11-13 23:48:51]

lgtm

[rmacnak, 2013-11-14 18:38:00]

Committed patchset #3 manually as r30280 (presubmit successful).