Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: tests/standalone/vmservice/isolate_stacktrace_command_test.dart

Issue 68113019: Filter frames from debugger stack based on visibility rather than "debuggability" (steppability). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix comment Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « runtime/vm/debugger.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library isolate_stacktrace_command_test; 5 library isolate_stacktrace_command_test;
6 6
7 import 'test_helper.dart'; 7 import 'test_helper.dart';
8 import 'package:expect/expect.dart'; 8 import 'package:expect/expect.dart';
9 9
10 class StacktraceTest extends VmServiceRequestHelper { 10 class StacktraceTest extends VmServiceRequestHelper {
11 StacktraceTest(port, id) : 11 StacktraceTest(port, id) :
12 super('http://127.0.0.1:$port/isolates/$id/stacktrace'); 12 super('http://127.0.0.1:$port/isolates/$id/stacktrace');
13 13
14 onRequestCompleted(Map reply) { 14 onRequestCompleted(Map reply) {
15 Expect.equals('StackTrace', reply['type'], 'Not a StackTrace message.'); 15 Expect.equals('StackTrace', reply['type'], 'Not a StackTrace message.');
16 Expect.equals(4, reply['members'].length, 'Stacktrace is wrong length.'); 16 Expect.isTrue(4 <= reply['members'].length, 'Stacktrace is wrong length.');
17 // The number of frames involved in isolate message dispatch is an
18 // implementation detail. Only check that we got all the frames for user
19 // code.
17 Expect.equals('a', reply['members'][0]['name']); 20 Expect.equals('a', reply['members'][0]['name']);
18 Expect.equals('b', reply['members'][1]['name']); 21 Expect.equals('b', reply['members'][1]['name']);
19 Expect.equals('c', reply['members'][2]['name']); 22 Expect.equals('c', reply['members'][2]['name']);
20 Expect.equals('myIsolateName', reply['members'][3]['name']); 23 Expect.equals('myIsolateName', reply['members'][3]['name']);
21 } 24 }
22 } 25 }
23 26
24 class IsolateListTest extends VmServiceRequestHelper { 27 class IsolateListTest extends VmServiceRequestHelper {
25 IsolateListTest(port) : super('http://127.0.0.1:$port/isolates'); 28 IsolateListTest(port) : super('http://127.0.0.1:$port/isolates');
26 29
(...skipping 11 matching lines...) Expand all
38 process.launch().then((port) { 41 process.launch().then((port) {
39 var test = new IsolateListTest(port); 42 var test = new IsolateListTest(port);
40 test.makeRequest().then((_) { 43 test.makeRequest().then((_) {
41 var stacktraceTest = new StacktraceTest(port, test._isolateId); 44 var stacktraceTest = new StacktraceTest(port, test._isolateId);
42 stacktraceTest.makeRequest().then((_) { 45 stacktraceTest.makeRequest().then((_) {
43 process.requestExit(); 46 process.requestExit();
44 }); 47 });
45 }); 48 });
46 }); 49 });
47 } 50 }
OLDNEW
« no previous file with comments | « runtime/vm/debugger.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698